Repository navigation
Conversation
Keep axes legends unchanged while making bin handles and labels available through the standard Matplotlib axes method. Preserve formatting, colors and additional labeled artists. Fixes python-windrose#293.
Collaborator
|
I don't speak for the whole project, just for myself. But as a brown South American climate scientist I will not review or merge any "AI" PRs like this one. It is against everything I believe. |
Contributor
|
Was my thought too. Basically AI-slop. I would be in favor of closing. |
Author
|
thanks for taking a look, this was for #293 where there was no way to get the legend handles from a shared legend, i reproduced it, added the accessor and covered it with tests that pass on the full suite, i get it if it's not a fit for the project and i'm fine with whatever you decide |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #293.
get_legend_handles_labels()currently returns no windrose bin entries, so the shared figure legend in the issue's example is empty.Reuse the existing bin handles and label formatting for this method. It returns the windrose bins followed by any ordinary labeled Matplotlib artists, without creating or replacing an axes legend. Decimal places and units are supported, and existing axes legends keep the same output.
Tested:
The fork test run also corrects the Ubuntu runner condition so its image-comparison steps actually run. That workflow-only adjustment is not part of this PR. Docs and packaging use the same source and tests.
Before:

After:
